fix(preinstall): run preinstall before reify

[wraithgar]

This puts the preinstall life cycle script where it belongs,
i.e. before the actual installation/reify has taken place.

References

Found during research for #2690

[wraithgar]

Historical context on why it is like this is because apparently people complained that dependencies weren't available during preinstall

[ljharb]

I’m confused, how could any dependencies be available pre install?

[wraithgar]

I’m confused, how could any dependencies be available pre install?

They can't. I don't know why this was changed to accommodate that but because it was we have a tougher decision.

This may need to be thrown on the "Fix the life cycle scripts for real" pile that would constitute a major change.

[ljharb]

ahhh i get it, that's the reason that the default branch is the way it is; this PR fixes that.

LGTM :-)

[wraithgar]

Closing this as the change is a breaking one and this needs to be ironed out in a new "what are even lifecycle events" to happen after we have actually documented all the lifecycle events.