Skip to content

fix: owner rm at local pkg not work #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: owner rm at local pkg not work #1971

wants to merge 1 commit into from

Conversation

@ShangguanQuail
Copy link

@ShangguanQuail ShangguanQuail commented Oct 16, 2020 •
edited
Loading

when exec npm owner rm <user> without package name at local package folder, npm will exec add while it's expected to exec rm

@ShangguanQuail ShangguanQuail requested a review from a team as a code owner October 16, 2020 03:17
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release Needs Review release: next These items should be addressed in the next release labels Oct 16, 2020
@ruyadorno ruyadorno mentioned this pull request Oct 16, 2020
Merged
@ruyadorno ruyadorno closed this in 5cf71c6 Oct 16, 2020
@ruyadorno
Copy link
Contributor

ruyadorno commented Oct 16, 2020

Thanks @ShangguanQuail 😄 landed in 5cf71c6

@MylesBorins MylesBorins mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShangguanQuail @ruyadorno @darcyclarke