Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: match npm-exec.md -p usage with lib/exec.js #1970

Closed
wants to merge 1 commit into from
Closed

docs: match npm-exec.md -p usage with lib/exec.js #1970

wants to merge 1 commit into from

Conversation

dr-js
Copy link
Contributor

@dr-js dr-js commented Oct 16, 2020

updated usage from: https://github.com/npm/cli/blob/v7.0.1/lib/exec.js#L8-L20,
and removed extra -p occurrences to avoid confusion.

@dr-js
docs: match npm-exec.md -p usage with lib/exec.js
05a52a7 
updated usage from: https://github.com/npm/cli/blob/v7.0.1/lib/exec.js#L8-L20,
and removed extra `-p` occurrences to avoid confusion.
@dr-js dr-js requested a review from a team as a code owner October 16, 2020 03:10
@dr-js dr-js mentioned this pull request Oct 17, 2020
Closed
@dr-js
Copy link
Contributor Author

dr-js commented Oct 17, 2020

Side note: I can't see the difference of <pkg>[@<version>] with npm exec and <pkg>[@<specifier>] with npx from the doc, should further link or explanation being added, or it's OK use <specifier> for both?

@darcyclarke darcyclarke added Needs Review Release 7.x work is associated with a specific npm 7 release labels Oct 17, 2020
@ruyadorno ruyadorno added release: next These items should be addressed in the next release and removed Needs Review labels Nov 3, 2020
@isaacs isaacs mentioned this pull request Nov 3, 2020
Merged
@isaacs isaacs closed this in 52d32d1 Nov 3, 2020
@dr-js dr-js deleted the patch-1 branch November 4, 2020 01:14
@MylesBorins MylesBorins mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-js @ruyadorno @darcyclarke