view: directly print to process.stdout #1791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in npm 7 output of npm view is being printed by a call to console.log which is causing an extra newline on output compared to npm 6. Replace the call to console.log with process.stdout.write to avoid this. Fixes: npm#1639
MylesBorins
commented
Sep 10, 2020
isaacs
previously requested changes
Sep 10, 2020
|
updated, PTAL |
ruyadorno
approved these changes
Sep 11, 2020
|
FWIW we probably want to modify / update the commit text when landing since it is no longer accurate |
darcyclarke
added
Bug
LEILN197
approved these changes
Sep 15, 2020
ruyadorno
pushed a commit
that referenced
this pull request
Sep 16, 2020
Currently in npm 7 output of npm view is being printed by a call to console.log which is causing an extra newline on output compared to npm 6. Replace the call to console.log with process.stdout.write to avoid this. Fixes: #1639 PR-URL: #1791 Credit: @MylesBorins Close: #1791 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in npm 7 output of npm view is being printed
by a call to console.log which is causing an extra newline
on output compared to npm 6. Replace the call to console.log
with process.stdout.write to avoid this.
Fixes: #1639