fix: fix package spec parsing during cache add process #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build fails because of coverage report, not sure what to do here, should I add tests for all cases? |
darcyclarke
added
the
Release 7.x
ruyadorno
approved these changes
Sep 4, 2020
|
Thanks @mjeanroy 😊 we're going to merge this fix into the next pre-release. For now we're just going to skip the unit tests since the reporter is very picky now and the file would need to have 100% LOC coverage in order to pass. 🙃 |
isaacs
pushed a commit
that referenced
this pull request
Sep 4, 2020
|
merged in d6b134f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a fix for #1734
It fixes the spec "parsing" during the cache add command.
References
Close #1734