Isaacs/fix tests and fail properly #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag no longer exists. We just always exit now when we're done.
Also, test this with a mock, so that tests pass in CI.
ruyadorno
reviewed
Aug 25, 2020
| @@ -323,6 +323,9 @@ t.test('npm.load', t => { | |||
| ]) | |||
| t.same(consoleLogs, [['@foo']]) | |||
| }) | |||
|
|
|||
| // need this here or node 10 will improperly end the promise ahead of time | |||
| await new Promise((res) => setTimeout(res)) | |||
There was a problem hiding this comment.
this is crazy hacky, would love to learn about the edge case going on here
ruyadorno
pushed a commit
that referenced
this pull request
Aug 25, 2020
* Also, test this with a mock, so that tests pass in CI. * test: streamline snapshot on config test * test: add workaround for node 10's broken promises * test: make cache dir cross-platform consistent in config test PR-URL: #1719 Credit: @isaacs Close: #1719 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the exit code properly when a command fails.
Fix the failure that our CI wasn't detecting for this reason.