test: add lib/logout.js unit tests #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed config.delete to remove from user config on logout - Tidy up lib/logout.js code - Added test/lib/logout.js
isaacs
approved these changes
Aug 21, 2020
| if (scope) { | ||
| const scopedRef = npm.flatOptions[regRef] | ||
| reg = scopedRef || reg | ||
| } |
There was a problem hiding this comment.
could get rid of a let with something like this:
const { registry, scope } = npm.flatOptions
const regRef = scope ? `${scope}:registry` : 'registry'
const reg = npm.flatOptions[regRef] || registryThere was a problem hiding this comment.
ooohh looks better yeah! feel free to fix it in the patch commit 😊
isaacs
pushed a commit
that referenced
this pull request
Aug 21, 2020
- Fixed config.delete to remove from user config on logout - Tidy up lib/logout.js code - Added test/lib/logout.js PR-URL: #1698 Credit: @ruyadorno Close: #1698 Reviewed-by: @isaacs
|
Landed on 7.0.0-beta.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/logout.jscodetest/lib/logout.jsunit tests