Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor adduser #1664

Closed
wants to merge 1 commit into from
Closed

chore: refactor adduser #1664

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

  • Refactored lib/auth modules
    • Removed some of the extra wrappers from cb to promises
    • Replaced impl to favor usage of async/await
  • Added test/lib/auth unit tests

@ruyadorno
chore: refactor adduser
91b8aa4 
- Refactored lib/auth modules
  - Removed some of the extra wrappers from cb to promises
  - Replaced impl to favor usage of async/await
- Added test/lib/auth unit tests
@ruyadorno ruyadorno requested a review from a team as a code owner August 12, 2020 16:21
@ruyadorno ruyadorno added the Release 7.x work is associated with a specific npm 7 release label Aug 14, 2020
isaacs pushed a commit that referenced this pull request Aug 18, 2020
@ruyadorno @isaacs
chore: refactor adduser
85027f4 
- Refactored lib/auth modules
  - Removed some of the extra wrappers from cb to promises
  - Replaced impl to favor usage of async/await
- Added test/lib/auth unit tests

PR-URL: #1664
Credit: @ruyadorno
Close: #1664
Reviewed-by: @isaacs
@ruyadorno ruyadorno closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruyadorno