Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] please update the doc of npm install <folder> #3358

Closed
jcompagner opened this issue Jun 3, 2021 · 1 comment · Fixed by #4428
Closed

[DOC] please update the doc of npm install <folder> #3358

jcompagner opened this issue Jun 3, 2021 · 1 comment · Fixed by #4428
Labels
Bug thing that needs fixing Documentation documentation related issue

Comments

@jcompagner
Copy link

see my case here: #3318

if that is not fixed the doc must be corrected because what it says there is just not right

https://docs.npmjs.com/cli/v7/commands/npm-install

"
npm install :

Install the package in the directory as a symlink in the current project. Its dependencies will be installed before it's linked. If sits inside the root of your project, its dependencies may be hoisted to the top-level node_modules as they would for other types of dependencies.
"

The dependencies are not installed, which is a major problem for us so i rather have that that is fixed
But if that case is just kept close, please update the doc because its just not true that that happens

What happens for us is that we have a main project somewhere on disk
and that project can depend on other library projects also somewhere on disk (can be in a different partition)

the main project has no idea of the dependencies of those other library projects they are fully configured for them selfs

we run (they are angular projects) "ng build -watch" in both projects and then the main has installed the dist folders of the output of those libs.

Those lib projects can't be in a subdir of the main, they all have there own git repo's , the libs don't belong in the git repo of the main.

Now we just have to manually install the dependencies of all the lib projects (there can be multiply) in to the main. (at least for development, and we have to make sure never to commit that package.json)

So how can this be solved better?
why is there a different between:

npm install subfolder\xxxx (inside main dir)

and

npm install ..\otherfolder\xxxxx (outside main dir)

We can't make it a tarbal (npm pack) because we really run "ng build -watch" in them and we really are developing the lib project(s)

@mdkrieg
Copy link

mdkrieg commented Jun 24, 2021

I am also interested in this outcome.

@darcyclarke darcyclarke added Bug thing that needs fixing Documentation documentation related issue labels Dec 1, 2021
manekinekko added a commit to manekinekko/cli that referenced this issue Feb 16, 2022
npm install <folder> doesn't install dependencies if <folder> is outside of root project.

Fixes npm#3358
wraithgar pushed a commit that referenced this issue Feb 16, 2022
npm install <folder> doesn't install dependencies if <folder> is outside of root project.

Fixes #3358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Documentation documentation related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants