-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] npm i add invalid version to package.json #2320
Comments
cc @ruyadorno |
Maybe |
eesh, that seems too magic to me. |
Kind of off-topic, sorry. Bottom line, we shouldn't be saving a dep range with a prefix attached to an empty version field 😅 |
So it's a dependabot bug? 🤔 (See DimensionDev/Maskbook#2073) |
* Do not save with ^ and no version Fix: #2320
I think I'm suggesting a SemVer feature request, actually. Dependabot is fine 😅 |
Steps To Reproduce:
Run
npm i sub
in/
. Sub package will be linked (that is correct). But wrong item is added to/package.json
"sub": "^"
, which should be"sub": "*"
because sub doesn't have a version field.Environment:
The text was updated successfully, but these errors were encountered: