Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --silent suppresses output from run commands #1958

Closed
G-Rath opened this issue Oct 14, 2020 · 4 comments
Closed

[BUG] --silent suppresses output from run commands #1958

G-Rath opened this issue Oct 14, 2020 · 4 comments
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Oct 14, 2020

Previously in pre-npm 7 --silent would only silence output from npm, meaning that run would still output the output from whatever is being run.

Now, it silences everything, meaning we can't use --silent to silence the npm ERR! messages that follow whenever a command fails.

Current Behavior:

> npm run typecheck --silent

Expected Behavior:

> npm run typecheck --silent

src/audit.ts:137:13 - error TS2345: Argument of type 'AuditMetadata | NpmAuditMetadataV2' is not assignable to parameter of type 'AuditMetadata'.
  Type 'NpmAuditMetadataV2' is missing the following properties from type 'AuditMetadata': devDependencies, optionalDependencies, totalDependencies

137             auditOutput.metadata
                ~~~~~~~~~~~~~~~~~~~~


Found 1 error.

Steps To Reproduce:

Environment:

  • OS: Ubuntu 18.04 (via WSLv1, Windows 10)
  • Node: 14.4.0
  • npm: 7.0.0
@G-Rath G-Rath added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Oct 14, 2020
@ljharb

This comment has been minimized.

@G-Rath

This comment has been minimized.

@isaacs
Copy link
Contributor

isaacs commented Oct 20, 2020

Very on-brand for this issue, folks 😆
Screen Shot 2020-10-19 at 17 17 02

@darcyclarke
Copy link
Contributor

Should be fixed as of 7.0.3

@darcyclarke darcyclarke removed the Needs Triage needs review for next steps label Nov 12, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 19 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants