[BUG] Replace deprecated "request" by "got"

[guimard]

What / Why

request has bee deprecated : request/request#3142

Here is a patch that removes this dependency:

--- a/lib/doctor/get-latest-nodejs-version.js
+++ b/lib/doctor/get-latest-nodejs-version.js
@@ -1,5 +1,5 @@
 var log = require('npmlog')
-var request = require('request')
+var request = require('got')
 var semver = require('semver')

 function getLatestNodejsVersion (url, cb) {
@@ -7,9 +7,8 @@
   tracker.info('getLatestNodejsVersion', 'Getting Node.js release information')
   var version = 'v0.0.0'
   url = url || 'https://nodejs.org/dist/index.json'
-  request(url, function (e, res, index) {
+  request(url).then(res => {
     tracker.finish()
-    if (e) return cb(e)
     if (res.statusCode !== 200) {
       return cb(new Error('Status not 200, ' + res.statusCode))
     }
@@ -22,6 +21,10 @@
       cb(e)
     }
   })
+  .catch(e => {
+    tracker.finish()
+    return cb(e)
+  })
 }

 module.exports = getLatestNodejsVersion

[darcyclarke]

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is reproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.