-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: splits out smoke-tests from publish-dryrun tests (#8069)
This removes the `publish.sh --smoke-publish` like from the current
`smoke-publish-test.sh` (renaming it to `smoke-test.sh`) and runs both
operations as seperete jobs within the `ci.yml` (on pr) and
`ci-release.yml` (on merge) workflow.
Why? To avoid changed files / git dirty issues from one operation to the
next.
With this PR we should have the same checks that merge has, on pr as
well, preventing scenarios where a PR breaks a `smoke test` or `publish
--smoke-publish` test. The only difference between merge / pr is that
merge has more tested node versions, if PRs start to pass but fail in
these version lets add the full matrix.
```sh
npm i npm@latest -g && node scripts/git-dirty.js && node scripts/resetdeps.js && ./scripts/smoke-tests.sh
```
```sh
npm i npm@latest -g && node scripts/git-dirty.js && node scripts/resetdeps.js && node ./scripts/publish.js --pack-destination=${pwd} --smoke-publish=true
```- Loading branch information
Showing
6 changed files
with
228 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,45 @@ | ||
| {{> ciReleaseYml }} | ||
| {{> ciReleaseYml }} | ||
|
|
||
| smoke-publish: | ||
| # This cant be tested on Windows because our node_modules directory | ||
| # checks in symlinks which are not supported there. This should be | ||
| # fixed somehow, because this means some forms of local development | ||
| # are likely broken on Windows as well. | ||
| {{> jobMatrixYml | ||
| jobName="Smoke Publish" | ||
| jobCheckout=(obj ref="${{ inputs.ref }}") | ||
| jobCreateCheck=(obj sha="${{ inputs.check-sha }}") | ||
| windowsCI=false | ||
| macCI=false | ||
| }} | ||
| - name: Smoke Publish | ||
| run: ./scripts/smoke-publish-test.sh | ||
| - name: Conclude Check | ||
| uses: LouisBrunner/checks-action@v1.6.0 | ||
| if: steps.create-check.outputs.check-id && always() | ||
| with: | ||
| token: $\{{ secrets.GITHUB_TOKEN }} | ||
| conclusion: $\{{ job.status }} | ||
| check_id: $\{{ steps.create-check.outputs.check-id }} | ||
| smoke-tests: | ||
| # This cant be tested on Windows because our node_modules directory | ||
| # checks in symlinks which are not supported there. This should be | ||
| # fixed somehow, because this means some forms of local development | ||
| # are likely broken on Windows as well. | ||
| {{> jobMatrixYml | ||
| jobName="Smoke Tests" | ||
| jobCheckout=(obj ref="${{ inputs.ref }}") | ||
| jobCreateCheck=(obj sha="${{ inputs.check-sha }}") | ||
| windowsCI=false | ||
| macCI=false | ||
| }} | ||
| - name: Smoke Tests | ||
| run: ./scripts/smoke-tests.sh | ||
| - name: Conclude Check | ||
| uses: LouisBrunner/checks-action@v1.6.0 | ||
| if: steps.create-check.outputs.check-id && always() | ||
| with: | ||
| token: $\{{ secrets.GITHUB_TOKEN }} | ||
| conclusion: $\{{ job.status }} | ||
| check_id: $\{{ steps.create-check.outputs.check-id }} | ||
|
|
||
| publish-dryrun: | ||
| # This cant be tested on Windows because our node_modules directory | ||
| # checks in symlinks which are not supported there. This should be | ||
| # fixed somehow, because this means some forms of local development | ||
| # are likely broken on Windows as well. | ||
| {{> jobMatrixYml | ||
| jobName="Publish Dry-Run" | ||
| jobCheckout=(obj ref="${{ inputs.ref }}") | ||
| jobCreateCheck=(obj sha="${{ inputs.check-sha }}") | ||
| windowsCI=false | ||
| macCI=false | ||
| }} | ||
| - name: Publish Dry-Run | ||
| run: node ./scripts/publish.js --pack-destination=$RUNNER_TEMP --smoke-publish=true | ||
| - name: Conclude Check | ||
| uses: LouisBrunner/checks-action@v1.6.0 | ||
| if: steps.create-check.outputs.check-id && always() | ||
| with: | ||
| token: $\{{ secrets.GITHUB_TOKEN }} | ||
| conclusion: $\{{ job.status }} | ||
| check_id: $\{{ steps.create-check.outputs.check-id }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters