fixup! feat(pack): add pack-destination config

npm · Jun 17, 2021 · 55435db · 55435db
1 parent 1d94c28
commit 55435db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/pack.js b/lib/pack.js
@@ -74,7 +74,7 @@ class Pack extends BaseCommand {
     for (const { arg, filename, manifest } of manifests) {
       const tarballData = await libpack(arg, this.npm.flatOptions)
       const pkgContents = await getContents(manifest, tarballData)
-      const tarballFilename = path.join(this.npm.config.get('pack-destination'), filename)
+      const tarballFilename = path.resolve(this.npm.config.get('pack-destination'), filename)
 
       if (!dryRun)
         await writeFile(tarballFilename, tarballData)

diff --git a/test/lib/pack.js b/test/lib/pack.js
@@ -53,7 +53,7 @@ t.test('should pack current directory with no arguments', (t) => {
 
     const filename = `npm-${require('../../package.json').version}.tgz`
     t.strictSame(OUTPUT, [[filename]])
-    t.strictSame(tarballFileName, filename)
+    t.strictSame(tarballFileName, path.resolve(filename))
     t.end()
   })
 })
@@ -87,7 +87,7 @@ t.test('follows pack-destination config', (t) => {
 
     const filename = `npm-${require('../../package.json').version}.tgz`
     t.strictSame(OUTPUT, [[filename]])
-    t.strictSame(tarballFileName, path.join('/tmp/test', filename))
+    t.strictSame(tarballFileName, path.resolve('/tmp/test', filename))
     t.end()
   })
 })