fix: in run-script, if loglevel is silent, disable banner option

Fixes issue #2023 PR-URL: #2086 Credit: @macno Close: #2086 Reviewed-by: @nlf
npm · Oct 30, 2020 · 2636fe1 · 2636fe1
1 parent 2a680e9
commit 2636fe1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/run-script.js b/lib/run-script.js
@@ -71,6 +71,7 @@ const runScript = async (args) => {
     stdio: 'inherit',
     stdioString: true,
     pkg,
+    banner: log.level !== 'silent',
   }
 
   for (const [event, args] of events) {

diff --git a/test/lib/run-script.js b/test/lib/run-script.js
@@ -253,6 +253,7 @@ t.test('skip pre/post hooks when using ignoreScripts', async t => {
           postenv: 'echo after the env',
           env: 'env'
         } },
+        banner: true,
         event: 'env'
       }
     ])
@@ -295,7 +296,8 @@ t.test('run silent', async t => {
         pkg: { name: 'x', version: '1.2.3', _id: 'x@1.2.3', scripts: {
           env: 'env'
         } },
-        event: 'env'
+        event: 'env',
+        banner: false
       },
       {
         event: 'postenv',