fix: don’t try to chmod unlinked files #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`linkGently` would return true if a link target had been visited before. `linkBin` would then chmod the link `to`, regardless of whether this file exists. This causes `npm install` to fail if multiple packages link to a non-existent bin with the same name. By returning false in `linkGently`, `linkBin` no skips the chmod on the non-existent file. Closes npm/cli#4597
|
Not sure why CI didn't kick off here. Tests pass for me locally. I'm gonna close/reopen to see if that makes the CI tests start. |
Closed
wraithgar
approved these changes
Jul 11, 2023
|
Thank you. Will land this after #82 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkGentlywould return true if a link target had been visited before.linkBinwould then chmod the linkto, regardless of whether this file exists. This causesnpm installto fail if multiple packages link to a non-existent bin with the same name.By returning false in
linkGently,linkBinno skips the chmod on the non-existent file.References
Fixes npm/cli#4597