fix: don’t try to chmod unlinked files #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkGently
would return true if a link target had been visited before.linkBin
would then chmod the linkto
, regardless of whether this file exists. This causesnpm install
to fail if multiple packages link to a non-existent bin with the same name.By returning false in
linkGently
,linkBin
no skips the chmod on the non-existent file.References
Fixes npm/cli#4597