Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

[BUG] another peerOptional ERESOLVE case #236

@isaacs

Description

@isaacs

Missed a case in #223

root -> (x, z@1)
x -> PEEROPTIONAL(y)
y -> PEER(z@2)

This is subtly similar to case A

case A, hidden to not be confusing
# case a
root -> (x, y@1)
x -> PEEROPTIONAL(z)
z -> PEER(y@2)

But, with the names spelled in such a way that the conflicted dep is not present in the peerSet tree until after the not-required peerOptional meta-peer is added. (They are sorted alphabetically for consistency.)

This code path wasn't being hit previously, and it's what prevents ng-packagr@11.1.3 from being installed alongside typescript@4. Ie,

x = ng-packagr@11.1.3
y = tsickle
z@1 = typescript@4
z@2 = typescript@~3.9.5

What / Why

n/a

When

  • n/a

Where

  • n/a

How

Current Behavior

  • n/a

Steps to Reproduce

  • n/a

Expected Behavior

  • n/a

Who

  • n/a

References

  • n/a

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions