feat: implement getAgent function #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
May 11, 2023
Comment on lines
+10
to
+15
| for (const [key, value] of Object.entries(process.env)) { | ||
| const lowerKey = key.toLowerCase() | ||
| if (['https_proxy', 'http_proxy', 'proxy', 'no_proxy'].includes(lowerKey)) { | ||
| proxyEnv[lowerKey] = value | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const [key, value] of Object.entries(process.env)) { | |
| const lowerKey = key.toLowerCase() | |
| if (['https_proxy', 'http_proxy', 'proxy', 'no_proxy'].includes(lowerKey)) { | |
| proxyEnv[lowerKey] = value | |
| } | |
| } | |
| for (const key in process.env) { | |
| const lowerKey = key.toLowerCase() | |
| if (['https_proxy', 'http_proxy', 'proxy', 'no_proxy'].includes(lowerKey)) { | |
| proxyEnv[lowerKey] = process.env[key] | |
| } | |
| } |
There was a problem hiding this comment.
Sadly, Object.entries does not return an iterator.
There was a problem hiding this comment.
This will "somewhat" nondeterministically clobber entries w/ duplicated content based on casing and I think we should acknowledge that here in this review and say "Yeah we don't support that"
wraithgar
reviewed
May 11, 2023
wraithgar
reviewed
May 11, 2023
| }) | ||
|
|
||
| if (matches) { | ||
| proxy = '' |
There was a problem hiding this comment.
this is weird, why an empty string instead of null or undefined?
wraithgar
reviewed
May 11, 2023
| } | ||
|
|
||
| const timeouts = [ | ||
| options.timeouts.connection || 0, |
There was a problem hiding this comment.
Should normalizeOptions do this?
wraithgar
reviewed
May 11, 2023
| options.timeouts.transfer || 0, | ||
| ].join('.') | ||
|
|
||
| const maxSockets = options.maxSockets || 15 |
There was a problem hiding this comment.
Should normalizeOptions do this/
wraithgar
reviewed
May 11, 2023
| const key = [ | ||
| `https:${isHttps}`, | ||
| proxyDescriptor, | ||
| `local-address:${options.localAddress || 'null'}`, |
There was a problem hiding this comment.
More defaults here, same question about normalizeOptions
wraithgar
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that i chose to remove the lambda specific handling, it doesn't make much sense to me to arbitrarily turn off keepalives just because a fetch is being performed in a lambda.
other than that, this is meant to be functionally equivalent to the
lib/agent.jsfile inmake-fetch-happen