Ignore parameters with ParameterDirection.ReturnValue (#5796)

(cherry picked from commit 28d41bf)
npgsql · Sep 4, 2024 · a220780 · a220780
1 parent d03c487
commit a220780
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Npgsql/NpgsqlCommand.cs b/src/Npgsql/NpgsqlCommand.cs
@@ -980,6 +980,9 @@ internal void ProcessRawQuery(SqlQueryParser? parser, bool standardConformingStr
                     if (EnableStoredProcedureCompatMode && parameter.Direction == ParameterDirection.Output)
                         continue;
 
+                    if (parameter.Direction == ParameterDirection.ReturnValue)
+                        continue;
+
                     if (isFirstParam)
                         isFirstParam = false;
                     else

diff --git a/test/Npgsql.Tests/FunctionTests.cs b/test/Npgsql.Tests/FunctionTests.cs
@@ -143,6 +143,25 @@ public async Task Too_many_output_params()
         Assert.That(command.Parameters["c"].Value, Is.EqualTo(-1));
     }
 
+    [Test, IssueLink("https://github.com/npgsql/npgsql/issues/5793")]
+    public async Task ReturnValue_parameter_ignored()
+    {
+        await using var conn = await OpenConnectionAsync();
+        var funcName = await GetTempFunctionName(conn);
+        await conn.ExecuteNonQueryAsync(@$"CREATE FUNCTION {funcName}() RETURNS integer AS 'SELECT 8;' LANGUAGE 'sql'");
+        await using var cmd = new NpgsqlCommand(funcName, conn) { CommandType = CommandType.StoredProcedure };
+        var param = new NpgsqlParameter
+        {
+            ParameterName = "@ReturnValue",
+            NpgsqlDbType = NpgsqlDbType.Integer,
+            Direction = ParameterDirection.ReturnValue,
+            Value = 0
+        };
+        cmd.Parameters.Add(param);
+        Assert.That(cmd.ExecuteScalar(), Is.EqualTo(8));
+        Assert.That(param.Value, Is.EqualTo(0));
+    }
+
     [Test]
     public async Task CommandBehavior_SchemaOnly_support_function_call()
     {