Skip to content

Stop include data source connection string in service provider hashcode #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Mar 15, 2025
Merged

Stop include data source connection string in service provider hashcode #3501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,6 @@ public override int GetServiceProviderHashCode()
hashCode.Add(userRangeDefinition);
}

if (Extension.DataSource is not null)
{
hashCode.Add(Extension.DataSource.ConnectionString);
}

hashCode.Add(Extension.AdminDatabase);
hashCode.Add(Extension.PostgresVersion);
hashCode.Add(Extension.UseRedshift);
Expand Down
14 changes: 14 additions & 0 deletions test/EFCore.PG.Tests/NpgsqlDbContextOptionsExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,19 @@ public void Service_collection_extension_method_can_configure_npgsql_options(boo
}
}

[ConditionalFact]
public void Varying_data_source_connection_strings_do_not_cause_multiple_service_providers()
{
for (var i = 0; i < 21; i++)
{
var optionsBuilder = new DbContextOptionsBuilder<DbContext>();
var dataSource = NpgsqlDataSource.Create($"Host=localhost;Database={i};Include Error Detail=true;Username=admin;Password=admin");
optionsBuilder.UseNpgsql(dataSource);

using var context = new ApplicationDbContext(optionsBuilder.Options);
_ = context.Model;
}
}

private class ApplicationDbContext(DbContextOptions options) : DbContext(options);
}