Skip to content

Downgrade xunit back to 2.6.1 #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Downgrade xunit back to 2.6.1 #3094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageVersion Include="xunit" Version="2.6.6" />
<PackageVersion Include="xunit" Version="2.6.1" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.6" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
</ItemGroup>
Expand Down
25 changes: 0 additions & 25 deletions test/EFCore.PG.FunctionalTests/ModelBuilding/NpgsqlModelBuilderGenericTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ public class NpgsqlModelBuilderGenericTest : NpgsqlModelBuilderTestBase
{
public class NpgsqlGenericNonRelationship(NpgsqlModelBuilderFixture fixture) : NpgsqlNonRelationship(fixture)
{
// https://github.com/dotnet/efcore/issues/33059
public override void Can_add_multiple_indexes()
=> Assert.Throws<EqualException>(() => base.Can_add_multiple_indexes());

// PostgreSQL actually does support mapping multi-dimensional arrays, so no exception is thrown as expected
protected override void Mapping_throws_for_non_ignored_three_dimensional_array()
=> Assert.Throws<ThrowsException>(() => base.Mapping_throws_for_non_ignored_three_dimensional_array());
Expand All @@ -23,14 +19,6 @@ protected override TestModelBuilder CreateModelBuilder(

public class NpgsqlGenericComplexType(NpgsqlModelBuilderFixture fixture) : NpgsqlComplexType(fixture)
{
// https://github.com/dotnet/efcore/issues/33059
public override void Access_mode_can_be_overridden_at_entity_and_property_levels()
=> Assert.Throws<EqualException>(() => base.Access_mode_can_be_overridden_at_entity_and_property_levels());

// https://github.com/dotnet/efcore/issues/33059
public override void Complex_properties_not_discovered_by_convention()
=> Assert.Throws<EqualException>(() => base.Complex_properties_not_discovered_by_convention());

protected override TestModelBuilder CreateModelBuilder(
Action<ModelConfigurationBuilder>? configure)
=> new GenericTestModelBuilder(Fixture, configure);
Expand Down Expand Up @@ -66,26 +54,13 @@ protected override TestModelBuilder CreateModelBuilder(

public class NpgsqlGenericManyToMany(NpgsqlModelBuilderFixture fixture) : NpgsqlManyToMany(fixture)
{
// https://github.com/dotnet/efcore/issues/33059
public override void Can_use_implicit_shared_type_with_default_name_and_implicit_relationships_as_join_entity()
=> Assert.Throws<EqualException>(
() => base.Can_use_implicit_shared_type_with_default_name_and_implicit_relationships_as_join_entity());

protected override TestModelBuilder CreateModelBuilder(
Action<ModelConfigurationBuilder>? configure)
=> new GenericTestModelBuilder(Fixture, configure);
}

public class NpgsqlGenericOwnedTypes(NpgsqlModelBuilderFixture fixture) : NpgsqlOwnedTypes(fixture)
{
// https://github.com/dotnet/efcore/issues/33059
public override void Can_configure_chained_ownerships()
=> Assert.Throws<EqualException>(() => base.Can_configure_chained_ownerships());

// https://github.com/dotnet/efcore/issues/33059
public override void Can_configure_chained_ownerships_different_order()
=> Assert.Throws<EqualException>(() => base.Can_configure_chained_ownerships_different_order());

// PostgreSQL stored procedures do not support result columns
public override void Can_use_sproc_mapping_with_owned_reference()
=> Assert.Throws<InvalidOperationException>(() => base.Can_use_sproc_mapping_with_owned_reference());
Expand Down