Fix prepared transactions caused by case sensitive string comparison (#2624) #2625
Conversation
jhartmann123
force-pushed
the
2624-prepared-transactions
branch
from
9560c3c to
06646d2
Compare
|
Thanks @jhartmann123, yeah, this was pretty hacky. I'll take a look in a few days. |
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Thanks, this fix looks good.
More generally, doing a string lookup on the connection string is hacky; for example, there could theoretically be spaces in there, which are valid but which would cause detection failure.
A more complete solution would be to have a dictionary mapping the connection string to its Enlist setting, which we'd get once by actually parsing the connection string with NpgsqlConnectionStringBuilder. I didn't do this was to avoid the extra dictionary lookup each time, though that may be a bit exaggerated...
Will merge and backpotr this for now and see if others run into issues around it. Thanks for your contribution!
|
Backported to 7.0.2 via f711091 |
2 participants
Fixes #2624