Support for partners API #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nozzlegear can you please add the 2 new environment variables to the build settings? These are required to pass the new tests. Then you can merge. Let me know it's not all clear. |
|
Just saw this, I'll add it this weekend! I could use this API myself, excited to get it merged.
…--
Josh Harms
On Thu, Feb 2, 2023, at 23:24, Clement Gutel wrote:
@nozzlegear <https://github.com/nozzlegear> can you please add the 2 new environment variables to the build settings?
These are required to pass the new tests.
Then you can merge.
Let me know it's not all clear.
—
Reply to this email directly, view it on GitHub <#836 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7B3SZYKCNGS4Y5XZPLWVSJBLANCNFSM6AAAAAAUP3CHX4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@nozzlegear have you been able to add the 2 new env variables to get the new tests running? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://shopify.dev/api/partner
This includes the PartnerService, some tests and enhancements to the leaky bucket policy because the Partners API has its own rate limits.
Running the tests requires 2 new environment variables:
SHOPIFYSHARP_ORG_ID => The Id of a partner organization. When logged in the partner dashboard, it shows in the url after https://partners.shopify.com/
SHOPIFYSHARP_ORG_TOKEN => Within the partner dashboard, go to Settings then click 'Manage Partner API clients'. Then create a dummy client for testing. Ensure you grant the 'View financials', required to run run and copy the access token in the environment variable.
