Add ListForFulfillmentAsync method to FulfillmentService #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the 'Retrieves filfillments associated with a fulfillment order' endpoint documented here: https://shopify.dev/api/admin-rest/latest/resources/fulfillment#get-fulfillment-orders-fulfillment-order-id-fulfillments The method arguments are ambiguous with `ListAsync`, so to distinguish the two this is named similarly to `CreateForFulfillmentAsync`.
thomotron
force-pushed
the
feature/list-fulfillment-by-fulfillmentorder
branch
from
4b78097 to
6336fda
Compare
|
Thanks @thomotron! Do you think this method would make more sense in the |
nozzlegear
added
missing or invalid methods
new method/endpoint
and removed
missing or invalid methods
labels
|
Given it's returning fulfilments I would imagine it would be best under And yeah |
nozzlegear
approved these changes
Feb 18, 2023
nozzlegear
added
missing or invalid endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the 'Retrieves fulfillments associated with a fulfillment order' endpoint from the REST API. It allows listing fulfilments from a particular fulfilment order.
This endpoint is available for for API versions 2022-04 and above.
The method arguments are ambiguous with
ListAsync, so to distinguish the two this is named similarly toCreateForFulfillmentAsync.The test requires a fulfilment order ID, so the FulfillmentService instance was roped in to deal with that.
I haven't added an entry to the README for this one but I'm happy to if needed.