Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Charge.test serialization #806

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

clement911
Copy link
Collaborator

Ensure that Charge.Test and RecurringCharge.Test property is always serialized so that the FalseToNullConverter can kick in.

The FalseToNullConverter wasn't kicking in because the serializer uses NullValueHandling.Ignore
This is fixed by applying NullValueHandling.Include at the property level.

I personally think this converter should be removed altogether, but some people might rely on the fact that this the Test property should always return either false or true and never null. The API seems to accept false values.

Maybe we can remove FalseToNullConverter.cs altogether in the major/breaking release.

@clement911 clement911 merged commit 7528eb5 into nozzlegear:master Nov 11, 2022
@nozzlegear
Copy link
Owner

I agree, this seems like a good one to remove in 6.0.

@nozzlegear nozzlegear added object updating Bugs and strange behavior around updating objects, primarly related to #284 revisit in 6.0 labels Nov 11, 2022
@clement911
Copy link
Collaborator Author

thanks. looks like you did a great job with respect to the build pipeline and release workflow. very easy to use!

@nozzlegear
Copy link
Owner

Glad you like it! I want to take another look at the pipeline soon so that both of us can approve full releases to nuget for Minor and Patch releases, but require reviews/approval for Major releases. I'm pretty sure that's possible but I need to review the github actions docs and figure out how to incorporate it in the scripts.

@clement911 clement911 deleted the charge-test-fix branch November 27, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object updating Bugs and strange behavior around updating objects, primarly related to #284 revisit in 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants