Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
Charge.Test
andRecurringCharge.Test
property is always serialized so that theFalseToNullConverter
can kick in.The
FalseToNullConverter
wasn't kicking in because the serializer usesNullValueHandling.Ignore
This is fixed by applying
NullValueHandling.Include
at the property level.I personally think this converter should be removed altogether, but some people might rely on the fact that this the
Test
property should always return either false or true and never null. The API seems to accept false values.Maybe we can remove
FalseToNullConverter.cs
altogether in the major/breaking release.