Update to API version 2022-07 #801
Conversation
…llmentAsync method
|
😁 |
|
For some reason I thought I had already done this! I was getting ready to do 2022-10 and realized I never got this one in like I thought. |
|
2022-10 might be a tricky one because of customer protection data new requirements. |
|
Ah that’s a good point, I’m not sure what the best way to handle that will be yet. My own app is going to be subject to the new protection requirements so I’ll need to get it ready, but if I remember correctly they gave me until July 2023 at the latest to upgrade. I think new apps have less time to do it.
…--
Josh Harms
On Thu, Oct 20, 2022, at 19:31, Clement Gutel wrote:
2022-10 might be a tricky one because of customer protection data new requirements.
Some Shopify users might not want to migrate until they get approved.
—
Reply to this email directly, view it on GitHub <#801 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7BFXZLNS4BEKZADVIDWEHP7JANCNFSM6AAAAAARKSIZHQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
DO NOT UPGRADE TO 2022-10!! This will cause major issues for apps because of the customer protection data. It might take a while before all your users get this approval, and they have until July 2023 to get this. Probably best to wait until March/April 2023 |
|
We could potentially do the following: This way, users could decide if they want to keep using 2022-07 for some time, until they are ready to move to 2022-10. |
|
It would indeed be great to get |
|
Thanks for the reminder! I'm working on merging and publishing this today. |
|
All the tests pass for this, I'm just not quite sure where I left off so I don't know if this has all of the changes for 2022-07 incorporated yet. |
|
I had a look at https://shopify.dev/api/release-notes/2022-07 and I believe this PR already removes all deprecated endpoints. |
|
Thanks for checking! I agree, I had a look and it looks like everything deprecated is removed. And the new fulfillment endpoints are all implemented, tests are passing for them. Not sure why I never merged this. |
|
look good to me |
|
can we merge & release? |
|
Not quite, got a few tests that started failing once I changed the API version to 2022-07. I'm fixing them right now, shouldn't be long!
…--
Josh Harms
On Mon, Jan 9, 2023, at 19:41, Clement Gutel wrote:
can we merge & release?
—
Reply to this email directly, view it on GitHub <#801 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOE7HXRLZJJNM4G2MSJ2TWRS435ANCNFSM6AAAAAARKSIZHQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
The checkout sales channel is disabled on ShopifySharp's dev store. Most likely this is due to the dev store's age.
Using DateTime.MaxValue would throw an ArgumentOutOfRangeException with message "The UTC time represented when the offset is applied must be between year 0 and 10,000."
|
Okay, current status is all tests are passing except for the
|
|
I imagine it's because the app you're testing with is not configured an a sales channel.
It could be that they changed the behaviour in 2022-07 to return 404 instead of empty results? |
|
Thanks, good catch! I'll test it with a sales channel app and see if it works. If so I'll just disable the tests and merge. |
Private/custom apps cannot use sales channel APIs and therefore the tests can't be run.
No description provided.