feat(js): Revise localization keys DX #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
reviewed
Aug 23, 2024
packages/js/src/ui/types.ts
Outdated
| @@ -55,7 +55,7 @@ export type NovuProviderProps = BaseNovuProviderProps & { | |||
| }; | |||
|
|
|||
| export enum NotificationStatus { | |||
| UNREAD_READ = 'unreadRead', | |||
| UNREAD_READ = 'all', | |||
There was a problem hiding this comment.
☑ chore: that's not meaning all, because all is: "unread+read+archived+unarchived"
There was a problem hiding this comment.
Do you think it matters that much for the key? I also did not like unreadRead as the name here. Should we name it Inbox or home or sth?
There was a problem hiding this comment.
yes, I think it might confuse the users if we call it all as the localization key
There was a problem hiding this comment.
you changed the name for the enum but not the localization key
desiprisg
force-pushed
the
com-157-revise-appearance-localization-dx
branch
from
a9d88bd
to
4843803
Compare
LetItRock
approved these changes
Aug 28, 2024
desiprisg
force-pushed
the
com-157-revise-appearance-localization-dx
branch
from
4843803
to
8ba755c
Compare
desiprisg
force-pushed
the
com-157-revise-appearance-localization-dx
branch
from
8ba755c
to
5bc3339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer