chore(novu, framework, worker, application-generic): Publish prerelease and improve types #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Jul 19, 2024
|
|
||
| export const emailProviderSchemas = { | ||
| [EmailProviderIdEnum.SendGrid]: sendgridProviderSchemas, | ||
| [EmailProviderIdEnum.SendGrid]: genericProviderSchemas, |
There was a problem hiding this comment.
This interface is going to change next week, so we are reverting all Providers to the generic schema for now. This is reverting a change that has not yet been published, so is considered non-breaking.
antonjoel82
approved these changes
Jul 19, 2024
rifont
changed the title
SokratisVidros
approved these changes
Jul 24, 2024
Yes, there's just a few tests failures to address and then we'll merge. The types are much simpler and deduplicated between Framework & Platform now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
@novu/framework@2.0.0-canary.4servehandler supportnovu@2.0.0-canary.8HeadercomponentanyusageScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer