-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): vite poc #6009
base: next
Are you sure you want to change the base?
feat(web): vite poc #6009
Conversation
apps/web/index.html
Outdated
@@ -2,7 +2,7 @@ | |||
<html lang="en"> | |||
<head> | |||
<!-- Google Tag Manager --> | |||
<% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %> | |||
<!-- <% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to find a replacement
const handleOnChange = useDebouncedCallback(async (type: OnChangeType, data: any, id?: string) => { | ||
onChange(type, data, id); | ||
}, TYPING_DEBOUNCE_TIME_MS); | ||
*/ | ||
|
||
const handleOnChange = (type: OnChangeType, data: any, id?: string) => {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Fix
export const useDebouncedCallback = function () {}; /* | ||
export { useDebouncedCallback } from '@mantine/hooks'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: This is failing the build for some reason
@@ -39,7 +39,7 @@ REDIS_CLUSTER_KEY_PREFIX= | |||
SYNC_PATH=http://127.0.0.1:3001 | |||
API_ROOT_URL=http://127.0.0.1:3000 | |||
DISABLE_USER_REGISTRATION=false | |||
PORT=1337 | |||
PORT=1336 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligning on port 1336 for api testing.
TODO:
14px
fonts are converted to0.875rem
instead of1rem