This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Cut down the notils-android AndroidManifest.xml #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. These should be decided by the application using the library. |
|
I actually thought it still needed an empty |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating
notils-androidinto one of our projects, gradle sync was failing due to manifest merger errors.This was because both the project in question and
notils-androidwere defining theandroid:supportsRtldirective in their manifests'applicationtags.Due to a bug detailed here - https://code.google.com/p/android/issues/detail?id=193679 - there is no way to specify which
supportsRtldirective should be replaced.So in order to combat this, I removed as much of
notils-android's manifest as I could. It's not actually an application anyway, so this should be fine.I tested this after cutting down the manifest by rebuilding the .aar file locally and adding that into one of our projects. Everything worked fine, there was no problem with gradle sync or running tests or the app itself.