Update methods to dcheck{ToSend,Received}OrEmpty()

Summary: All but 1 of the ~12 callsites of these methods on my stack should be fine with "empty SocketFds". Reviewed By: Gownta Differential Revision: D45668462 fbshipit-source-id: 391384ba233a5c388a37d78beb81274ba7439e48
novitae · May 13, 2023 · ace41c0 · ace41c0
1 parent 1f23eee
commit ace41c0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/folly/io/async/fdsock/SocketFds.h b/folly/io/async/fdsock/SocketFds.h
@@ -83,12 +83,12 @@ class SocketFds final {
     DCHECK(!ptr_);
     return *this;
   }
-  SocketFds& dcheckReceived() {
-    DCHECK(std::holds_alternative<Received>(*ptr_));
+  SocketFds& dcheckReceivedOrEmpty() {
+    DCHECK(!ptr_ || std::holds_alternative<Received>(*ptr_));
     return *this;
   }
-  SocketFds& dcheckToSend() {
-    DCHECK(std::holds_alternative<ToSend>(*ptr_));
+  SocketFds& dcheckToSendOrEmpty() {
+    DCHECK(!ptr_ || std::holds_alternative<ToSend>(*ptr_));
     return *this;
   }