Skip to content

Comments

vis: remove empty shares from updates#85

Merged
sondove merged 1 commit intonovem-code:mainfrom
sondove:sen/fix-share-purge
Apr 28, 2025
Merged

vis: remove empty shares from updates#85
sondove merged 1 commit intonovem-code:mainfrom
sondove:sen/fix-share-purge

Conversation

@sondove
Copy link
Contributor

@sondove sondove commented Apr 28, 2025

We incorrectly included an empty PUT to the share api as part of setting the shared to empty

@sondove sondove requested a review from myme April 28, 2025 21:02
Copy link
Collaborator

@myme myme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@myme myme linked an issue Apr 28, 2025 that may be closed by this pull request
@sondove sondove merged commit 2fd5935 into novem-code:main Apr 28, 2025
8 checks passed
@sondove sondove deleted the sen/fix-share-purge branch April 28, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api: errors when clearing a share

2 participants