workflows: skip nix check

[bjornars]

No description provided.

[Copilot]

Pull request overview

This PR temporarily disables the Nix checks job in the CI workflow by adding a conditional skip.

Key Changes

• Added if: false condition to skip the "Nix Checks" job

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment 'skip for now' lacks context about why the check is being skipped and when it should be re-enabled. Consider adding a reference to a tracking issue or ticket, or a more detailed explanation of the reason for skipping.

Suggested change

	if: false # skip for now
	if: false # Temporarily disabled due to flake check instability, see https://github.com/your-org/your-repo/issues/123. Re-enable once the issue is resolved.

[myme]

🙈

[sondove]

It's not obvious to me that we should disable these tests. I've seen the nix test catch errors that was not caught in other settings. This strict build thing is a feature IMO.

We should try to understand why these tests are failing and fix the underlying instead of ignoring it.

I vote against this skip, but I'll yield to the majority

[bjornars]

It's not obvious to me that we should disable these tests. I've seen the nix test catch errors that was not caught in other settings. This strict build thing is a feature IMO.

We should try to understand why these tests are failing and fix the underlying instead of ignoring it.

I vote against this skip, but I'll yield to the majority

Overruled 💔

Based on what I saw when I tried to make this work, this is not a real issue, but a nixpkgs thing. Quite possibly putting our lower-bound python3 version at 3.9 is the core reasons for the issues.

For our purposes, here's my defintion of "good":

• poetry run novem ✅
• poetry build && pipx install --force dist/novem-0.5.6.tar.gz && novem ✅
• poetry build && pipx install --force dist/novem-0.5.6.tar.gz --python /opt/cpython39/bin/python3 ✅

Having it work with nix is a plus, but not a deal-breaker for me today.

[sondove]

Accepted, however, the nix workflows to me are not about making it work on nix, it's about making it pass in a very strict sandbox environment.

For example, i remember we had a path bug that was only caught in the nix tests, not any of the other ones. (But i'm sure @myme will fix the nix stuff and we can have best of both worlds again)