Skip to content

Comments

tags: add tag support#118

Merged
sondove merged 7 commits intonovem-code:mainfrom
sondove:sen/tags
Dec 12, 2025
Merged

tags: add tag support#118
sondove merged 7 commits intonovem-code:mainfrom
sondove:sen/tags

Conversation

@sondove
Copy link
Contributor

@sondove sondove commented Dec 11, 2025

This adds support for tags in python code and cli

@sondove
Copy link
Contributor Author

sondove commented Dec 11, 2025

This is based on #117 so probably a good idea to merge that first

@myme
Copy link
Collaborator

myme commented Dec 12, 2025

This is based on #117 so probably a good idea to merge that first

It would've been good for this to be stacked by targeting #117, because the diff on this PR includes also all of those changes and it makes it a bit more difficult to distinguish between the changes. But seems like this doesn't really work with branches in remote forks. At least I'm not able to change the base to the 117 branch 👎

@sondove
Copy link
Contributor Author

sondove commented Dec 12, 2025

This is based on #117 so probably a good idea to merge that first

It would've been good for this to be stacked by targeting #117, because the diff on this PR includes also all of those changes and it makes it a bit more difficult to distinguish between the changes. But seems like this doesn't really work with branches in remote forks. At least I'm not able to change the base to the 117 branch 👎

I did target that branch when I made it. But let me try and change

Copy link
Collaborator

@myme myme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🏷️

One comment is I tried to set multiple tags in one go, and it seems to only set the last -t argument:

image

Tried also with novem -p test-plot -t +foo -t +bar -C.

I think supporting multiple tags either through --append or some separator character would serve a nice use-case.

@sondove
Copy link
Contributor Author

sondove commented Dec 12, 2025

Looks good 🏷️

One comment is I tried to set multiple tags in one go, and it seems to only set the last -t argument:

I've added support for comma separated tag lists

@sondove sondove merged commit 504b748 into novem-code:main Dec 12, 2025
4 checks passed
@sondove sondove deleted the sen/tags branch December 12, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants