Skip to content

workflows: add the Github App config to the release workflow #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjornars merged 1 commit into from
Dec 11, 2025
Merged

workflows: add the Github App config to the release workflow #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/python-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,18 @@ jobs:
permissions:
contents: write
steps:
- name: Generate GitHub App token
id: app-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.APP_ID }}
private-key: ${{ secrets.APP_PRIVATE_KEY }}

- uses: actions/checkout@v4
with:
ref: main
fetch-depth: 0
token: ${{ steps.app-token.outputs.token }}

- name: Set up Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -48,20 +57,22 @@ jobs:
poetry build

- name: Commit version bump
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
run: |
git config user.name "github-actions[bot]"
git config user.email "github-actions[bot]@users.noreply.github.com"

# Show status for debugging
git status
# Explicitly set the remote URL with the app token
git remote set-url origin https://x-access-token:${GH_TOKEN}@github.com/${{ github.repository }}.git
Copy link
Collaborator

@myme myme Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick suggestion: If you use the repository key of the checkout step set to this string you might not need to explicitly set-url later?

- uses: actions/checkout@v6
  with:
    # Repository name with owner. For example, actions/checkout
    # Default: ${{ github.repository }}
    repository: ''

Copy link
Contributor Author

@bjornars bjornars Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lifted straight from the vscode-repo, so at least this works 🤷


# Add changed files
git add pyproject.toml poetry.lock novem/version.py

# Only commit if there are changes
if ! git diff --cached --quiet; then
git commit -m "Release v$VERSION"
git push origin HEAD:main
git push origin main
else
echo "No changes to commit"
fi
Expand Down