Ledger/sign #404
Merged
Ledger/sign #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
valentunn
commented
Aug 31, 2022
valentunn
commented
antonijzelinskij
approved these changes
Aug 31, 2022
| android:id="@+id/sign_ledger_nav_graph" | ||
| app:startDestination="@id/signLedgerFragment"> | ||
|
|
||
|
|
| } | ||
| } | ||
|
|
||
| private fun View.transition(fadedOut: () -> Unit) { |
There was a problem hiding this comment.
What do you think about name with more context. for example fadeTransition
There was a problem hiding this comment.
Agree. Though animation might change in the future so I think it is better to name it smth like stateChangeTransition
|
Gonna fix PR comments in #405 to avoid merge conflicts |
valentunn
added a commit
that referenced
this pull request
Sep 1, 2022
valentunn
added a commit
that referenced
this pull request
Sep 1, 2022
* Add/change ledger chain account * Code style * Fix - bottom sheet does not open after cancellation * Fix PR comments from #404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.