Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI for prop cancellation #573

Merged
merged 6 commits into from
Dec 16, 2022
Merged

UI for prop cancellation #573

merged 6 commits into from
Dec 16, 2022

Conversation

EricDevito
Copy link
Contributor

  • Only available to proposer during pending/active/queued proposal states

@EricDevito
UI for prop cancellation
051fdf8 
- Only available to proposer during pending/active/queued proposal states
@netlify
Copy link

netlify bot commented Sep 23, 2022 •
edited
Loading

✅ Deploy Preview for nouns-home ready!

Name Link
🔨 Latest commit 5fa5184
🔍 Latest deploy log https://app.netlify.com/sites/nouns-home/deploys/639a420e912a2400085fa93c
😎 Deploy Preview https://deploy-preview-573--nouns-home.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 23, 2022 •
edited
Loading

✅ Deploy Preview for nouns-testnet ready!

Name Link
🔨 Latest commit 5fa5184
🔍 Latest deploy log https://app.netlify.com/sites/nouns-testnet/deploys/639a420e49fdf600089319e4
😎 Deploy Preview https://deploy-preview-573--nouns-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@solimander
Copy link
Collaborator

The button text is not rendering correctly. Presumably because it's inside a Trans tag and there is no accompanying translation.

text

@EricDevito
Copy link
Contributor Author

The button text is not rendering correctly. Presumably because it's inside a Trans tag and there is no accompanying translation.

text

addressed translation issues via yarn i18n:extract EricDevito@e121951

@EricDevito
Update index.tsx
5fa5184 
typo desturctiveTransitionStateButton -> destructiveTransitionStateButton
solimander
solimander approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@solimander solimander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@solimander solimander merged commit 59b706f into nounsDAO:master Dec 16, 2022
@EricDevito EricDevito deleted the Cancel-prop-UI branch March 1, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solimander solimander solimander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricDevito @solimander