Hide session page commands #22

giordano-lucas · 2026-01-30T09:43:33Z

Greptile Overview

Greptile Summary

This PR refactors the CLI to deprecate session commands (observe, execute, scrape) by hiding them and promoting page commands as the primary interface for browser interactions.

Key Changes

Hidden notte sessions observe/execute/scrape commands (set Hidden: true) with comments directing users to use notte page commands instead
Refactored notte page observe and notte page scrape to proxy directly to runSessionObserve and runSessionScrape functions
Updated flag names for consistency: --main-only → --only-main-content
Removed duplicate test implementations in page_test.go that are now covered by sessions_test.go
Added comprehensive test coverage for scrape command with various flag combinations
Updated all documentation and templates across the repository to use page commands
Hidden notte functions run-metadata-update command

Issues Found

README.md: Two instances showing incorrect notte page scrape syntax using positional arguments instead of --instructions flag (lines 133, 404)

Confidence Score: 4/5

This PR is safe to merge after fixing the documentation syntax errors
The refactoring is well-executed with proper code organization, comprehensive test coverage, and consistent updates across documentation. The core logic correctly proxies page commands to session commands. However, the README documentation has syntax errors showing incorrect command usage that would confuse users
README.md needs corrections to scrape command syntax (lines 133, 404)

Important Files Changed

Filename	Overview
README.md	Updated documentation to use page commands instead of session commands, but has incorrect scrape command syntax
internal/cmd/page.go	Refactored page commands to proxy to session commands, properly using shared implementation
internal/cmd/sessions.go	Hidden deprecated commands (observe, execute, scrape) with appropriate comments directing users to page commands
tests/integration/page_commands_test.go	Updated integration tests to use --instructions flag and --only-main-content flag correctly

- Set Hidden: true on sessionsObserveCmd, sessionsExecuteCmd, sessionsScrapeCmd - Update README.md to document page commands as the primary interface - Update skills documentation (SKILL.md, session-management.md) - Update shell templates to use notte page commands The hidden commands still work for backward compatibility but are no longer shown in --help output, encouraging users to use the cleaner page interface.

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

skills/notte-browser/SKILL.md

giordano-lucas · 2026-01-30T09:51:36Z

@greptile

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

README.md

Eliminates code duplication by making page observe/scrape directly call their sessions counterparts. Unifies command-line interface to use consistent flag names across both command groups. Key changes: - Remove duplicate runPageObserve and runPageScrape functions (~70 lines) - Unify flag variables: use sessionObserveURL and sessionScrapeOnlyMain - Standardize interface: page scrape now uses --instructions flag instead of positional arg - Update runSessionObserve to print only description in text mode for consistency - Add 4 comprehensive unit tests for scrape argument combinations - Update all documentation and templates to use unified interface

giordano-lucas · 2026-01-30T10:10:34Z

@greptile

greptile-apps

_{6 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

tests/integration/page_commands_test.go

skills/notte-browser/templates/data-extraction.sh

skills/notte-browser/references/session-management.md

giordano-lucas · 2026-01-30T10:20:54Z

@greptile

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-30T10:24:02Z

README.md

+
+```bash
+notte page observe                    # Get page state and available actions
+notte page scrape [instructions]      # Scrape content from the page 


The scrape command no longer accepts positional arguments - instructions must be passed via the --instructions flag

Suggested change

notte page scrape [instructions] # Scrape content from the page

notte page scrape --instructions "..." # Scrape content from the page

Prompt To Fix With AI

This is a comment left during a code review. Path: README.md Line: 133:133 Comment: The `scrape` command no longer accepts positional arguments - instructions must be passed via the `--instructions` flag ```suggestion notte page scrape --instructions "..." # Scrape content from the page ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-30T10:24:02Z

README.md

+2. `notte page goto <url>` - Navigate to a URL
+3. `notte page observe` - Get interactive elements with IDs (@B1, @B2)
+4. `notte page click @B1` / `notte page fill @B2 "text"` - Interact using element IDs
+5. `notte page scrape "..."` - Extract structured data


The scrape command no longer accepts positional arguments - instructions must be passed via the --instructions flag

Suggested change

5. `notte page scrape "..."` - Extract structured data

5. `notte page scrape --instructions "..."` - Extract structured data

Prompt To Fix With AI

This is a comment left during a code review. Path: README.md Line: 404:404 Comment: The `scrape` command no longer accepts positional arguments - instructions must be passed via the `--instructions` flag ```suggestion 5. `notte page scrape --instructions "..."` - Extract structured data ``` How can I resolve this? If you propose a fix, please make it concise.

giordano-lucas added 2 commits January 30, 2026 10:42

hide other cmd as well

8a2f3ee

giordano-lucas self-assigned this Jan 30, 2026

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

skills/notte-browser/SKILL.md Outdated Show resolved Hide resolved

fix some formatting issues

bcf71fb

giordano-lucas force-pushed the hide-session-page-commands branch from e50cc05 to bcf71fb Compare January 30, 2026 09:51

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

giordano-lucas added 2 commits January 30, 2026 11:07

Fix duplicate step numbering in README workflow

ec52f0d

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

address reviewer feedback

c110cbd

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

address reviewer feedback

c97a88a

giordano-lucas merged commit ae99dac into main Jan 30, 2026
3 checks passed

	notte page scrape [instructions] # Scrape content from the page
	notte page scrape --instructions "..." # Scrape content from the page

	5. `notte page scrape "..."` - Extract structured data
	5. `notte page scrape --instructions "..."` - Extract structured data

Hide session page commands #22

Hide session page commands #22

Uh oh!

Conversation

giordano-lucas commented Jan 30, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Key Changes

Issues Found

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

giordano-lucas commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

giordano-lucas commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

giordano-lucas commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

giordano-lucas commented Jan 30, 2026 •

edited by greptile-apps bot

Loading