Code quality fix - Exception handlers should preserve the original exception #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There is a JDK 6 issue with https://docs.oracle.com/javase/7/docs/api/java/lang/AssertionError.html#AssertionError(java.lang.String,%20java.lang.Throwable) I am fine w/ removing JDK6 - and just supporting 7 / 8 but wanted to mention, @civanyp |
Collaborator
|
I am really tempted to remove JDK_6 - especially that JDK_8 can be tested now via Travis_CI :-) |
Contributor
Author
|
Sorry, I did a mistake by deleting the branch. |
Contributor
Author
|
Great thanks! |
Contributor
Author
|
Updated! |
cemcatik
pushed a commit
to cemcatik/java-apns
that referenced
this pull request
Apr 11, 2017
…lers-fix-1 Code quality fix - Exception handlers should preserve the original exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1166 - “Exception handlers should preserve the original exception”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1166
Please let me know if you have any questions.
Christian