-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switched from notional-labs/ibc-go/v3 to cosmos/ibc-go/v3 #23
switched from notional-labs/ibc-go/v3 to cosmos/ibc-go/v3 #23
Conversation
thank you! ya know I'd forgotten this step and it is important for sure. |
right! anything we forgot to include in this PR? |
No I think that this is correct. I am sorry about the slow review: juno. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending review by @catShaark
I think our update is flawed because we don't have the code to support ica for wasmd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yesss
@catShaark @oopcode would you guys mind having a look at branch ica-v3? branch ica-v3 is:
@catShaark we're about to deploy ica/cw to dig-- is there an issue? tag: v0.25.0-ica |
I'm putting an issue to ibc-go now, I will propose that they remove
Issue now is cw no support ica, how about we ship without ica |
This PR replaces a custom upgrade to ibc v3 by notional labs to the "official" upgrade by the ibc-go team (cosmos/ibc-go#1205)