This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
colour fixes #47
Merged
colour fixes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which bug report or feature request do these changes address?
light gray tags missing - notion-enhancer/notion-enhancer#894
gruvbox dark tag colours not applying - notion-enhancer/notion-enhancer#888
list and timeline tag colours not applying - notion-enhancer/notion-enhancer#888
also added: apply theme variables to the palette of colours when selecting a tag/background colour
What does your code do and why?
missing light gray tags - added in separately as they only exist in boards and tags.
added a light gray colour variation to all themes, most of them are just the existing gray colour lightened by 30%.
gruvbox dark tag colours not applying - variables were named
--gruvbox_light--...instead of--gruvbox_dark--..., fixed this.list and timeline tag colours not applying - the tags have a style
padding-left: 8pxbut the selector used6px. removed the6px;to select the extra tags.apply theme variables to menu preview - selector on line 295-7 of
_mapColors.jsand 429-447 (vanilla notion uses callout colours for the highlight palette, changed this to actual highlight colours because highlights are probably used more than callouts. feel free to change back to callout colour if you want.)tested on extension and browser, have not noticed any selectors picking up on too much.