Skip to content

Bug fixes #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Bug fixes #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b3a00c
Fix serialization exception on sync blocks
HermanSchoenfeld Mar 11, 2023
6cfcbcf
Fix heading blocks to support toggles
HermanSchoenfeld Mar 12, 2023
06ea4f4
Fixed synced block serialization (#1)
HermanSchoenfeld May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Src/Notion.Client/Models/Blocks/HeadingOneBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class HeadingOneBlock : Block, IColumnChildrenBlock, INonColumnBlock

public override BlockType Type => BlockType.Heading_1;

public override bool HasChildren => false;

public class Info
{
[JsonProperty("rich_text")]
Expand All @@ -23,6 +21,9 @@ public class Info
[JsonProperty("color")]
[JsonConverter(typeof(StringEnumConverter))]
public Color? Color { get; set; }

[JsonProperty("is_toggleable")]
public bool IsToggleable { get; set; }
}
}
}
5 changes: 3 additions & 2 deletions ...lient/Models/Blocks/HeadingThreeeBlock.cs → ...Client/Models/Blocks/HeadingThreeBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class HeadingThreeBlock : Block, IColumnChildrenBlock, INonColumnBlock

public override BlockType Type => BlockType.Heading_3;

public override bool HasChildren => false;

public class Info
{
[JsonProperty("rich_text")]
Expand All @@ -23,6 +21,9 @@ public class Info
[JsonProperty("color")]
[JsonConverter(typeof(StringEnumConverter))]
public Color? Color { get; set; }

[JsonProperty("is_toggleable")]
public bool IsToggleable { get; set; }
}
}
}
5 changes: 3 additions & 2 deletions Src/Notion.Client/Models/Blocks/HeadingTwoBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class HeadingTwoBlock : Block, IColumnChildrenBlock, INonColumnBlock

public override BlockType Type => BlockType.Heading_2;

public override bool HasChildren => false;

public class Info
{
[JsonProperty("rich_text")]
Expand All @@ -23,6 +21,9 @@ public class Info
[JsonProperty("color")]
[JsonConverter(typeof(StringEnumConverter))]
public Color? Color { get; set; }

[JsonProperty("is_toggleable")]
public bool IsToggleable { get; set; }
}
}
}
1 change: 1 addition & 0 deletions Src/Notion.Client/Models/Blocks/IBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ namespace Notion.Client
[JsonSubtypes.KnownSubTypeAttribute(typeof(ParagraphBlock), BlockType.Paragraph)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(PDFBlock), BlockType.PDF)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(QuoteBlock), BlockType.Quote)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(SyncedBlockBlock), BlockType.SyncedBlock)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(TableBlock), BlockType.Table)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(TableRowBlock), BlockType.TableRow)]
[JsonSubtypes.KnownSubTypeAttribute(typeof(TableOfContentsBlock), BlockType.TableOfContents)]
Expand Down