Skip to content

Rename Text prop to String in Formula property filter 🚚 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Rename Text prop to String in Formula property filter 🚚 #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Src/Notion.Client/Models/Filters/FormulaFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ public class FormulaFilter : SinglePropertyFilter

public FormulaFilter(
string propertyName,
TextFilter.Condition text = null,
TextFilter.Condition @string = null,
CheckboxFilter.Condition checkbox = null,
NumberFilter.Condition number = null,
DateFilter.Condition date = null)
{
Property = propertyName;
Formula = new Condition(
text: text,
@string: @string,
checkbox: checkbox,
number: number,
date: date
Expand All @@ -25,8 +25,8 @@ public FormulaFilter(

public class Condition
{
[JsonProperty("text")]
public TextFilter.Condition Text { get; set; }
[JsonProperty("string")]
public TextFilter.Condition String { get; set; }

[JsonProperty("checkbox")]
public CheckboxFilter.Condition Checkbox { get; set; }
Expand All @@ -38,12 +38,12 @@ public class Condition
public DateFilter.Condition Date { get; set; }

public Condition(
TextFilter.Condition text = null,
TextFilter.Condition @string = null,
CheckboxFilter.Condition checkbox = null,
NumberFilter.Condition number = null,
DateFilter.Condition date = null)
{
Text = text;
String = @string;
Checkbox = checkbox;
Number = number;
Date = date;
Expand Down