fix: INotifyWatcher may raise events with no paths #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INotifyWatcher hold inotify watch descriptors map `wd -> path` and after an `unwatch` call the descriptor is deleted from the map. In some cases, if a lot of events are raised, it may cause race condition when the descriptor has been deleted, but event with this descriptor has already been queued. In that case INotifyWatcher doesn't know the path and just ignore the event fixes notify-rs#678
|
In this PR I also have moved |
dfaust
reviewed
Jul 16, 2025
|
Thanks, @riberk. This looks very good. I can merge it now, or you can fix the typo first. Your call. |
Done, thanks for the fix |
|
Fantastic. Thanks again! |
|
@riberk I think this would be a good time to make a new release - unless you are working on something else. |
|
@dfaust it'd be good, but I don't know how I can help |
|
I will make the release. Just wanted to make sure I don't release while you are still working on something. I'll wait with the release until my latest MR is merged as well, though. |
|
Ah, now I see it. Right now I'm not working on anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INotifyWatcher hold inotify watch descriptors map
wd -> pathand after anunwatchcall the descriptor is deleted from the map. In some cases, if a lot of events are raised, it may cause race condition when the descriptor has been deleted, but event with this descriptor has already been queued. In that case INotifyWatcher doesn't know the path and just ignore the eventfixes #678