Fix compile error with MSVC #1837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC seems to define `sprintf_s` under `__STDC_WANT_SECURE_LIB__`. `__STDC_LIB_EXT1__` is undefined, causing the compiler to spit out this error: ```stb_image_write.h(763,15): error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.```
Owner
|
For reference, see also #1512 which I haven't figured out what to do with because I'm doubtful of the snprintf change. (I am not saying yours is a duplicate, don't close this. I just want to reference it for later.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC seems to define
sprintf_sunder__STDC_WANT_SECURE_LIB__.C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\ucrt\stdio.h
__STDC_LIB_EXT1__is undefined, causing the compiler to spit out this error:stb_image_write.h(763,15): error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.