-
Notifications
You must be signed in to change notification settings - Fork 83
Merge to dev/1.4.0 branch (Merged PR: #308) #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature custom style
…ter_naver_map into feature-custom-style
- NaverMap setCustomStyleId > onCustomStyleLoaded, onCustomStyleLoadFailed 핸들러를 NaverMapView 이벤트 리스너로 추가 - iOS 테스트 확인.
onCustomStyleLoaded, onCustomStyleLoadFailed 이벤트 리스너 추가
Revert "onCustomStyleLoaded, onCustomStyleLoadFailed 이벤트 리스너 추가"
Revert "Revert "onCustomStyleLoaded, onCustomStyleLoadFailed 이벤트 리스너 추가""
Revert "Merge branch 'feature-custom-style' into main"
…yle exceptions `NStyleLoadFailedException`, `NInvalidStyleException`, `NAnotherStyleLoadFailedException`, using `_NRawNativeException` on `NAuthFailedException`
…s on `onAuthFailed`
…led#exception` to `NStyleLoadFailedException`
…on `SdkInitializer.authorized.onAuthFailed` invocation
…on` on `SdkInitializer.onAuthFailedListener.onAuthFailed` invocation
…on `NaverMapController.onCustomStyleLoadFailed.onCustomStyleLoadFailed` invocation
…on` on `NaverMapController.onCustomStyleLoadFailed.onCustomStyleLoadFailed` invocation
…NaverMapViewOptions`.
…re-custom-style # Conflicts: # android/src/main/kotlin/dev/note11/flutter_naver_map/flutter_naver_map/applier/option/NaverMapApplierImpl.kt
…erMapController.remove` with override dispose method
…pController.removeChannel` with override dispose method
…ture/custom_style # Conflicts: # android/src/main/kotlin/dev/note11/flutter_naver_map/flutter_naver_map/applier/ApplyUtil.kt # android/src/main/kotlin/dev/note11/flutter_naver_map/flutter_naver_map/view/NaverMapView.kt # example/ios/Podfile.lock # example/pubspec.lock # ios/flutter_naver_map/Sources/flutter_naver_map/applier/ApplyUtil.swift # ios/flutter_naver_map/Sources/flutter_naver_map/applier/option/NaverMapOptionApplier.swift # ios/flutter_naver_map/Sources/flutter_naver_map/controller/NaverMapControlSenderExtensions.swift # ios/flutter_naver_map/Sources/flutter_naver_map/util/CalcUtil.swift # ios/flutter_naver_map/Sources/flutter_naver_map/util/DisplayUtil.swift # lib/src/controller/map/handler.dart # lib/src/widget/map_widget.dart
note11g
commented
Jul 14, 2025
Owner
Author
note11g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1차로 보았을 때, 1.4.0의 변경사항이 일부 사라진 부분이 있어 1.4.0으로 파일 몇가지의 내용을 돌려두었습니다. 추가 사항이 있는지 확인해보겠습니다.
Owner
Author
|
모두 정상적으로 최신코드가 반영된 것을 확인하였습니다. 머지합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.