Skip to content

fix: fix context and bump up golang.org/x/net for release-1.3 branch #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Two-Hearts
Copy link

This PR targets on the release-1.3 branch.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao previously approved these changes Dec 19, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (141bdf1) to head (16a4594).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3    #1120   +/-   ##
============================================
  Coverage        70.35%   70.35%           
============================================
  Files               46       46           
  Lines             2911     2911           
============================================
  Hits              2048     2048           
  Misses             670      670           
  Partials           193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts Two-Hearts changed the title fix: fix context and bump up golang/x/net for release-1.3 branch fix: fix context and bump up golang.org/x/net for release-1.3 branch Dec 19, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit fae91b7 into notaryproject:release-1.3 Dec 20, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch December 20, 2024 00:03
@Two-Hearts Two-Hearts mentioned this pull request Dec 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants