-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reload of server certificate #1403
base: master
Are you sure you want to change the base?
Conversation
Please sign your commits following these rules: $ git clone -b "certificate_rotation" git@github.com:krockpot/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Can one of the admins verify this patch? |
49e2594
to
2f73f0f
Compare
d4886d2
to
c636b38
Compare
3b7f642
to
9fceab8
Compare
c30b13d
to
0ca29a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for letting this languish. LGTM.
Noticed the dco/no tag is still one here. Please make sure all commits in this PR have the Signed off by line. This will block merging. |
1cda812
to
1da0db5
Compare
ah yeah I think that's because I used the update branch button in the UI. rebased manually. |
1da0db5
to
464f833
Compare
Unclear why CircleCI was waiting, so I'll just rebase from master again 🤷♂️ |
…le rotation cleanly). Signed-off-by: Jeremy Krach <jkrach@pinterest.com>
Signed-off-by: Jeremy Krach <jkrach@pinterest.com>
464f833
to
8f019ff
Compare
@endophage @justincormack should be good to merge (had to do a few rebases), I don't have perms to merge. |
sorry to spam but @cyli @endophage @justincormack any other actions before this can be merged? Thanks! |
Just wanted to follow up again and see if there is any official process to have this PR merged now that it's been accepted. Thanks! (@endophage) |
https://marcofranssen.nl/secure-2fa-ssh-and-pgp-using-krypton/#PGP-setup Here is also a guide which eases howto setup your GPG key |
For some use cases, the certificate configured on the host may be short lived and rotated regularly. Rather than restart notary, it makes sense for it to regularly update its certificate information based on what is at the configured path.