Skip to content

Conversation

dluvian
Copy link
Contributor

@dluvian dluvian commented Aug 3, 2025

Replace markers with nip22 style tags

@DanConwayDev @TheAwiteb

Copy link
Contributor

@TheAwiteb TheAwiteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanConwayDev
Copy link
Contributor

Concept ACK.
Imo the old tags should remain in the nip but be marked as depricated.
It should also be highlighted that this is a breaking change.
Gitworkshop and ngit both have support for fetching and associating statuses using this style. I can trivially switch them to issuing new statuses using this style as the nip is merged.
It also raises the question whether we should also switch to NIP-22 for patches.
I wrote #1799 which switched all nip34 events to NIP-22.
With the introduction of PRs in #1966 perhaps we have an opportunity to batch a bunch of these breaking changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants