-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-09: clarify "a" tag deletions #1293
Conversation
Can we make sure StrFry operates in this way? |
strfry does not support "a" tag deletions: https://github.com/hoytech/strfry/blob/master/src/events.cpp#L332 As much as I love strfry for its ingenuity and efficiency, it should not be regarded as the flagship relay implementation. It has quite a few bugs and is not actively being developed at the pace most of us are moving at. I don't think I will use strfry for future projects. It's actually not that hard to build a relay - way easier than building a client. Between a 150 line controller and 400 line storage adapter I have a relay that works better than strfry and supports all these features. It's not as efficient with storage but the functionality is better. |
I agree but the reality is that, right now, everyone runs StrFry. It has become the de-facto standard for Nostr. :( |
Lack of support on the relay side shouldn't block a-tag deletions. Clients that want to support them should be downloading them anyway, so it shouldn't make any real difference in end-user experience. |
What strfry does should basically not influence what we do with NIPs. Exactly @staab, was typing this at the same time. |
I just hope this doesn't become yet another NIP-26 that exists only on paper. |
"a" tag deletion is already in the spec. This is just a clarification of what is already documented, matching what all known implementations are already doing. Whether a-tag deletions are wrong does not really pertain to this MR. If we decide later it is still wrong for some reason, we can remove the original text. But as long as a-tag deletions are in this document, it's helpful to have the clarifying statement. |
Just to confirm, as explained in NIP-01, basically when a new replaceable event is published, older versions should be deleted, right? Lines 96 to 98 in d251ca0
|
Deleting a replaceable event is not well defined. It should delete all versions of the event up to the created_at timestamp of the deletion event itself, to allow the author to publish that kind of event in the future.